OCHA-DAP / ocha-anticipy

Python package to support the development of anticipatory action frameworks
https://github.com/OCHA-DAP/ocha-anticipy
GNU General Public License v3.0
8 stars 1 forks source link

Feature/add hrp countries #193

Closed caldwellst closed 1 year ago

caldwellst commented 1 year ago

So, I have put together the setup for the additional HRP countries. The only two countries missing are:

github-actions[bot] commented 1 year ago

Test Results

    4 files  ±  0      4 suites  ±0   33s :stopwatch: ±0s 101 tests +  3  101 :heavy_check_mark: +  3  0 :zzz: ±0  0 :x: ±0  404 runs  +12  404 :heavy_check_mark: +12  0 :zzz: ±0  0 :x: ±0 

Results for commit e3d2f0ed. ± Comparison against base commit 24ca241d.

:recycle: This comment has been updated with latest results.

codecov-commenter commented 1 year ago

Codecov Report

Merging #193 (e3d2f0e) into develop (24ca241) will increase coverage by 0.13%. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #193      +/-   ##
===========================================
+ Coverage    90.70%   90.84%   +0.13%     
===========================================
  Files           20       20              
  Lines         1324     1343      +19     
===========================================
+ Hits          1201     1220      +19     
  Misses         123      123              
Impacted Files Coverage Δ
src/ochanticipy/config/countryconfig.py 98.87% <100.00%> (+0.06%) :arrow_up:
src/ochanticipy/datasources/codab/codab.py 98.00% <100.00%> (+0.77%) :arrow_up:
src/ochanticipy/utils/hdx_api.py 100.00% <100.00%> (ø)
caldwellst commented 1 year ago

@turnerm Okay, have tried to address it all! Have a look and see what you think. Mainly think you should check the new documentation, wasn't sure best way to show all possibilities in the example for COD AB. I changed example to Nigeria because Nepal has new data so no longer had a custom layer name.