Closed Tinkaa closed 3 years ago
I am struggling a bit with how we can best define the variables that are now global variables (i.e. in capitals). Should they go to main()? Or is there a better way to do that? (@turnerm tagging you here as well since we have been talking about this)
I think they are find for now, ideally these will be refactored to config in the (hopefully very near) future so I wouldn't sweat it too much
The trigger_metrics
folder looks good to me. I think regarding the global variables and config files is fine, but really think that a single one linear of file paths called through os.path.join()
calling the raw strings rather than from config might be cleaner.
Thanks! Lets discuss how we can best define paths in a call :) Since no other comments, I will assume you approve it and merge it. If not, let me know.
Script to compute the predictive trigger for Malawi. It is very basic and not automated, but should only be run twice. I am planning to make tests for it later, and also probably some plotting function(s)
main()
? Or is there a better way to do that? (@turnerm tagging you here as well since we have been talking about this)trigger_metrics
folder. Do you think this structure and filenaming is suitable, also looking at the observational trigger?Also there was some problem with using incorrect coordinates when downloading the data. I haven't decided which version we will use for the monitoring yet, but implemented it such that it can easily be switched.