OCHA-DAP / pa-anticipatory-action

Code and documentation for analytical work on OCHA Anticipatory Action pilots.
GNU General Public License v3.0
14 stars 0 forks source link

arc2 data processing #289

Closed joseepoirier closed 2 years ago

joseepoirier commented 2 years ago

There are currently 2 files for your review:

1) to pull the .nc and extract the values (_data_pull.R) 2) to compute various variables including season onset/cessation/duration. (_data_analysis.R)

There is a .Rmd (coming to a PR near you in the near future) into which these two files will be sourced, and in which the reporting metrics will be computed per month etc. and plotted.

Notes:

In files # 1 and # 2, please poke around more intensely around these points:

Thanks!

joseepoirier commented 2 years ago

Thanks so much @caldwellst ! Glad to have had another set of eyes on the accuracy of the calculations. Bonus for pre-reviewing improvements to the code itself, too. :)

Sorry I didn't mean to have you review the .Rmd's yet..

caldwellst commented 2 years ago

No worries at all! I will double check all calculations again in the next review, because my code eyes are just dead now.

joseepoirier commented 2 years ago

No worries at all! I will double check all calculations again in the next review, because my code eyes are just dead now.

Completely understood! If it makes sense to wait until we have the full report ready for review and/or to pull a more complete dataset, don't hesitate to wait. At least we have a first pass so I can keep building on it.

caldwellst commented 2 years ago

Hey Josee! Got pinged again on this, but not sure if ready for review. Won't go through it yet, but let me know if you want it reviewed or any specific part reviewed and I will do so!

joseepoirier commented 2 years ago

@caldwellst Indeed it is not ready for your review. Just resumed work on it. Will ping you directly when it is ready.

joseepoirier commented 2 years ago

@caldwellst I am going to close this PR now. The full report will soon be ready for review and I'll send you a separate PR for that to include the Rmd.