search

OCHA-DAP / pa-flood-pilot-validation

0 stars 0 forks source link

No `time` dim in raw glofas #1

Open zackarno opened 1 year ago

zackarno commented 1 year ago

unlike floodscan, raw glofas does not seem to have dim named time therefore the following line in get_glofas_data() returns NULL which throws an error. Think I just need to change $time to $Number

https://github.com/OCHA-DAP/pa-flood-pilot-validation/blob/c1dd9295e46b1bd1b6cc83b811a4c4c88b06af0a/floodscan_validation/01_wrangling.R#L230

Just documenting this here for myself to look into later as I'm pivoting to station data aggregation work for the moment

caldwellst commented 1 year ago

On this, I think we are using the processed GLOFAS data from the ochanticipy library right? Is there still no time dimension in those output .nc files?

zackarno commented 1 year ago

im not sure, but if that is the case then maybe the foodscan_validation/01_wrangling.R file is drawing from different .nc files (not from ochaanticipy) because I encounter the error when I run through that script line by line. I get the error here:

https://github.com/OCHA-DAP/pa-flood-pilot-validation/blob/c1dd9295e46b1bd1b6cc83b811a4c4c88b06af0a/floodscan_validation/01_wrangling.R#L263-L279