search

OCHA-DAP / pa-flood-pilot-validation

0 stars 0 forks source link

Gauge flagging google #2

Closed zackarno closed 1 year ago

zackarno commented 1 year ago

initial gauge flagging work to better understand how we might aggregate gauges.

Gauge data is retrieved from downloaded spreadsheet in this example. I am creating a new branch which will access it via googlesheets

PaulineNimo commented 1 year ago

Perhaps you didn't push the change yet but you need to also change the names of the objects when loading them from nowcast to historical in hybas_exploration.Rmd.

zackarno commented 1 year ago

Perhaps you didn't push the change yet but you need to also change the names of the objects when loading them from nowcast to historical in hybas_exploration.Rmd.

Good catch! fixed here 56b55eb

caldwellst commented 1 year ago

Will review once all of the other branches are merged into here as a single setup. For now will review the email output just for visual and design comments.

zackarno commented 1 year ago

Will review once all of the other branches are merged into here as a single setup. For now will review the email output just for visual and design comments.

great - I am actually just going to close this PR as I've replaced it with one which merges everything up to this same point- plus adding some documentation/final steps