search

OCNS / SoftwareWG

The primary housekeeping repository for the INCF/OCNS Software Working Group, and the sources for the web site.
https://ocns.github.io/SoftwareWG/
11 stars 3 forks source link

feat: add welcome e-mail template for new members #47

Closed sanjayankur31 closed 3 years ago

sanjayankur31 commented 3 years ago

@OCNS/software-wg : could you please have a look at this?

kernfel commented 3 years ago

Hm, new to reviewing. Should I not have approved...? I only meant to approve on behalf of myself, not preclude further comments.

sanjayankur31 commented 3 years ago

Hm, new to reviewing. Should I not have approved...? I only meant to approve on behalf of myself, not preclude further comments.

I think when we select a team, anyone from the team can review on behalf of the team.

I guess I could tag folks individually too :thinking:

sanjayankur31 commented 3 years ago

we can have 15 reviewers, so I've added everyone I could there. As long as we get a few +1s, that'll be sufficient. I'll merge this at the end of the work week.

kernfel commented 3 years ago

In general, team is probably fine. Just need to get used to not approving right away, I guess.

appukuttan-shailesh commented 3 years ago

Looks good to me :+1:

jimperlewitz commented 3 years ago

Looks good

sanjayankur31 commented 3 years ago

We have a few approvals, so I'll go merge this now. Thanks folks :)