search

OCP-on-NERC / xdmod-openshift-scripts

0 stars 1 forks source link

Update script for cluster name and various annotations #2

Closed tzumainn closed 2 years ago

tzumainn commented 2 years ago

Cluster name is now set through an environment variable; annotations are retrieved from the openshift project.

joachimweyl commented 2 years ago

@tzumainn does this need reviews?

tzumainn commented 2 years ago

@joachimweyl yep! I mentioned it to rob; dunno if there's someone else that should be reviewing?

joachimweyl commented 2 years ago

@tzumainn can you please use GitHub as your single source of truth and add anybody you would like to review to the "reviewers" section?

tzumainn commented 2 years ago

@joachimweyl I actually tried that, but rob doesn't show up on the list of reviewers for this project and I don't have the rights to add him to this repository

joachimweyl commented 2 years ago

@tzumainn let me fix that. Thank you for the heads up. @larsks thank you for adding rob!

joachimweyl commented 2 years ago

@rob-baron just making sure this PR properly requested your review when you were added.

tzumainn commented 2 years ago

Thanks for the reviews! For reference, something like https://github.com/CCI-MOC/xdmod-cntr/commit/4be0bc3ec2b03902ab5e4d04537510bbf5d06067 is how a job would be setup.