OCP-on-NERC / xdmod-openshift-scripts

0 stars 1 forks source link

Update metrics query #3

Closed tzumainn closed 1 year ago

tzumainn commented 1 year ago

Recent versions no longer include metrics such as kube_pod_init_container_resource_limits_cpu_cores; instead they have kube_pod_init_container_resource_limits, with individual results having a unit attribute to filter by.

tzumainn commented 1 year ago

It would be good to also update the references to these metrics in the README.md file since they have changed.

Ah, great catch! I've updated the README - let me know if you spot anything else!

tzumainn commented 1 year ago

Looks like there is another place in the README that show the old metrics:

| ncpus          | *kube_pod_init_container_resource_requests_cpu_cores*  |
| req_cpus       | *kube_pod_init_container_resource_limits_cpu_cores*    |
| req_mem        | *kube_pod_init_container_resource_limits_memory_bytes* |

Whoops - fixed as well! I've searched for further uses of the string, so I think that should be all of them. Thanks for checking!