search

OCR-D / ocrd_all

Master repository which includes most other OCR-D repositories as submodules
MIT License
72 stars 17 forks source link

:package: v2022-03-25 #305

Closed kba closed 2 years ago

stweil commented 2 years ago

@kba, @bertsky, this release is broken because of the latest changes for ocrd_anybaseocr (which fails CI, too).

stweil commented 2 years ago

See CI fix #306.

bertsky commented 2 years ago

@stweil

this release is broken because of the latest changes for ocrd_anybaseocr (which fails CI, too).

yeah – it was meant to be integrated via #304, which seems to have slipped through. Your #306 is only half of the story.

bertsky commented 2 years ago

Your #306 is only half of the story.

correction: since I did publish pix2pixhd on PyPI in the end, we don't even have to checkout the submodule. So the current solution should be fine. (Therefore I have closed #304.)

(CircleCI still fails with the nagging pip race, though – OSError on missing pkg METADATA files. Perhaps we should downgrade to pip<21.3.1 – as pip>=22 is only available for Python>=3.7? Otherwise I am out of ideas what to try – to make -j and therefore the time limit work again.)

stweil commented 2 years ago

Otherwise I am out of ideas what to try

Drop CircleCI in favour of GitHub actions?

stweil commented 2 years ago

since I did publish pix2pixhd on PyPI in the end, we don't even have to checkout the submodule.

@bertsky, @kba, we still need https://github.com/OCR-D/ocrd_anybaseocr/pull/92 to fix the CI errors. That PR removes the pix2pixhd submodule.

bertsky commented 2 years ago

Drop CircleCI in favour of GitHub actions?

Your GH actions workflow does not build/upload Docker images, which is the main purpose of CI here.

stweil commented 2 years ago

I only wrote a first action which tests a build matrix of different Ubuntu and Python versions. Of course another action would have to be written to build and upload Docker images. That's what I suggested.

See for example https://github.com/marketplace/actions/build-and-push-docker-images.

stweil commented 2 years ago

@kba, I suggest to add future new tags for releases with git tag -a. The last annotated tag was v2020-09-25.