search

OCR-D / ocrd_all

Master repository which includes most other OCR-D repositories as submodules
MIT License
72 stars 17 forks source link

Use qualified names for Docker images #307

Closed stweil closed 2 years ago

stweil commented 2 years ago

This allows using podman instead of docker.

Signed-off-by: Stefan Weil sw@weilnetz.de

bertsky commented 2 years ago

This allows using podman instead of docker.

Interesting. Could you elaborate on that? (Here or in the README)

stweil commented 2 years ago

Podman is a drop-in replacement for Docker (so it is sufficient to link podman to docker to run with ocrd-all) and included in Debian / Ubuntu. The main difference is that it does not need a daemon and also can be run rootless. By default it does not assume that an image comes from docker.io. Using a qualified name tells it where those images come from (and also works with the normal Docker).

bertsky commented 2 years ago

I did not know that Podman is directly compatible with Docker images, and can pull from Drockerhub.

What about GPU usage and nvidia-docker daemon?

Linking podman to docker sounds good: Could you please edit the README to explain that possibility?

stweil commented 2 years ago

Before promoting podman it is necessary to test it in the OCR-D context. For example I simply don't know how good it can be used with GPU. Therefore I'd wait with mentioning it in the README.

stweil commented 2 years ago

Can I merge this PR?

kba commented 2 years ago

Before promoting podman it is necessary to test it in the OCR-D context Can I merge this PR?

Are we certain that this won't break anything with Docker / DockerHub deployment? I'd feel more comfortable with merging if we had running CI.

stweil commented 2 years ago

Before promoting podman it is necessary to test it in the OCR-D context Can I merge this PR?

Are we certain that this won't break anything with Docker / DockerHub deployment? I'd feel more comfortable with merging if we had running CI.

The change is only used in Dockerfile. Building a local Docker image is sufficient for a test.

See also these articles: https://windsock.io/referencing-docker-images/ https://www.redhat.com/en/blog/be-careful-when-pulling-images-short-name

stweil commented 2 years ago

See https://github.com/stweil/ocrd_all/runs/5758316217 which shows that the patch does not break the Docker image build.

bertsky commented 2 years ago

It's like a default namespace. Even without it, you can see docker.io top level when pushing or pulling against DH.

bertsky commented 2 years ago

Can I merge this PR?

I suggest placing the merge and release cycle in one hand whenever possible. That would be @kba ATM. See here

kba commented 2 years ago

Sry, this should have been part of the release, will fix right away.