OCR-D / ocrd_all

Master repository which includes most other OCR-D repositories as submodules
MIT License
72 stars 17 forks source link

Remove sbb-textline-detector #312

Closed cneud closed 2 years ago

cneud commented 2 years ago

I suggest removing the now obsolete sbb-textline-detector (superseded by Eynollah which is already part of ocrd_all).

I hope I have caught all places.

stweil commented 2 years ago

I hope I have caught all places.

See also README.md.

cneud commented 2 years ago

Just update README.md as well

Thanks and done!

(btw we have new versions of sbb_binarization and eynollah using TF2 ready, so maybe we can soon fully drop TF1 here!)

cneud commented 2 years ago

Builds on CircleCI failed due to (possibly unrelated?) errors

[...]
chmod +x /usr/local/bin/ocrd-segment-evaluate /usr/local/bin/ocrd-segment-from-masks /usr/local/bin/ocrd-segment-from-coco /usr/local/bin/ocrd-segment-extract-glyphs /usr/local/bin/ocrd-segment-extract-words /usr/local/bin/ocrd-segment-extract-lines /usr/local/bin/ocrd-segment-extract-regions /usr/local/bin/ocrd-segment-extract-pages /usr/local/bin/ocrd-segment-replace-original /usr/local/bin/ocrd-segment-replace-page /usr/local/bin/ocrd-segment-repair /usr/local/bin/ocrd-segment-project
. /usr/local/bin/activate && cd tesserocr && sem -q --will-cite --fg --id ocrd_all_piplocal pip install --timeout=3000  .
ERROR: Directory '.' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.
make: *** [/usr/local/share/tesserocr] Error 1
Makefile:675: recipe for target '/usr/local/share/tesserocr' failed
The command '/bin/sh -c set -a; bash docker.sh' returned a non-zero code: 2
Makefile:869: recipe for target 'docker-maximum-cuda' failed
make: *** [docker-maximum-cuda] Error 2

Exited with code exit status 2
CircleCI received exit code 2
stweil commented 2 years ago

Builds on CircleCI failed due to (possibly unrelated?) errors

Yes, the build fails because the tesserocr submodule was not fetched, so there is no setup.py.

stweil commented 2 years ago

@kba, https://hub.docker.com/r/ocrd/all also needs an update when sbb-textline-detector was removed.

stweil commented 2 years ago

@cneud, the first commit updated .gitmodules, but did not remove the directory sbb_textline_detector. Running git rm sbb_textline_detector would have done both. That caused the CI failure. I fixed that, so CI should now pass.

bertsky commented 2 years ago

Builds on CircleCI failed due to (possibly unrelated?) errors

Yes, the build fails because the tesserocr submodule was not fetched, so there is no setup.py.

That in turn was caused by the initial

fatal: no submodule mapping found in .gitmodules for path 'sbb_textline_detector'

You seem to have repaired that just now – let's see...

stweil commented 2 years ago

Thanks!