search

OCR-D / ocrd_all

Master repository which includes most other OCR-D repositories as submodules
MIT License
72 stars 18 forks source link

Docker build staged #436

Closed bertsky closed 5 months ago

bertsky commented 5 months ago

fixes #416 fixes #417 fixes #434 fixes #427

bertsky commented 5 months ago

Does anyone know why CircleCI (again) does not get triggered?

stweil commented 5 months ago

Does anyone know why CircleCI (again) does not get triggered?

I have no idea, but found only one other pull request where CircleCI did not run. Maybe both pull requests have something in common which prevents the CI runs?

bertsky commented 5 months ago

Please create separate pull requests for the commits that are not related to the staged Docker build. Some commits are easy to review and could be merged fast, but 11 commits in a single pull request makes it much more difficult to review, at least for me.

It would also be good to update ocrd_tesserocr with the latest Tesseract which includes several important improvements. Currently it uses a two months old release.

That's an unreasonable demand. We had no release for a long time, CI did not work for multiple reasons. This is the first attempt to get a workable ocrd_all again – I have to combine multiple changes, otherwise it would be without merit.

stweil commented 5 months ago

I have to combine multiple changes, otherwise it would be without merit.

Then good luck. I won't be able to review this pull request further.

bertsky commented 5 months ago

I triggered CI manually on my fork: