search

OCR-D / ocrd_all

Master repository which includes most other OCR-D repositories as submodules
MIT License
72 stars 17 forks source link

Check core submodule version is consistent with base image core version #443

Open kba opened 5 months ago

kba commented 5 months ago 
          > CI [failed as expected](https://app.circleci.com/pipelines/github/OCR-D/ocrd_all/1078/workflows/46661fe9-14c5-4eda-a549-959c7d1da24d/jobs/1489?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary) with
ocrd/core-cuda:v2.65.0 inconsistent with core version v2.65.0-1-gcc6ea575

which is good, but I update core in this PR as well to make sure it won't if all is set up properly.

Ah, but of course there is a catch. The check won't work if we derive from a non-versioned Docker base image such as ocrd/core:minimum-cuda.

I still think the check is a good idea and will open an issue for it but comment it out for now because we really need a new release urgently.

_Originally posted by @kba in https://github.com/OCR-D/ocrd_all/issues/442#issuecomment-2197187199_