search

OCR-D / ocrd_all

Master repository which includes most other OCR-D repositories as submodules
MIT License
71 stars 18 forks source link

Dockerfile: default for OCRD_MODULES was outdated #447

Open kba opened 1 month ago

kba commented 1 month ago

This only happens if users are building with docker build directly instead of through make docker* so we only noticed now. Perhaps it would be wise to change the Dockerfile to not have a default for OCRD_MODULES to encourage users to use the Makefile (which among other things makes sure that submodules are checked out).

bertsky commented 1 month ago

CI failure seems to come from:

#12 280.1 rm -f -rf /build/ocrd_tesserocr/build/tesseract
#12 280.1 cd repo/tesseract; make distclean
#12 280.1 make[2]: Entering directory '/build/ocrd_tesserocr/repo/tesseract'
#12 280.1 make[2]: Leaving directory '/build/ocrd_tesserocr/repo/tesseract'
#12 280.1 make[2]: *** No rule to make target 'distclean'.  Stop.
#12 280.1 make[1]: [Makefile:184: clean-tesseract] Error 2 (ignored)

So the clean-tesseract rule in ocrd_tesserocr seems to be wrong: https://github.com/OCR-D/ocrd_tesserocr/blob/d23992b0068e6fa9612cddcfe106628461538442/Makefile#L182-L184

bertsky commented 1 month ago

Fixed in ocrd_tesserocr master – please update that submodule here!

bertsky commented 1 month ago

Fixed in ocrd_tesserocr master – please update that submodule here!

wait – not fixed yet!

bertsky commented 1 month ago

Fixed in ocrd_tesserocr master – please update that submodule here!

wait – not fixed yet!

fixed now.