OCR-D / ocrd_calamari

Recognize text using Calamari OCR and the OCR-D framework
Apache License 2.0
13 stars 6 forks source link

Test loading/inference on all supported Python and TF versions #83

Closed mikegerber closed 1 year ago

mikegerber commented 1 year ago

Learning from qurator-spk/eynollah#87/qurator-spk/eynollah#87 I think we should test loading/test inference on all supported Python and TF versions. The worst that can happen is to learn what isn't working.

I'd do this after #61.

mikegerber commented 1 year ago

The best that can happen: Have an understanding of how to save a model so it can be loaded under all (supported) circumstances.

bertsky commented 1 year ago

Indeed. And to make it work better, as a precaution, we should try to get Calamari to support SavedModel format. In fact, the problem has already surfaced.

mikegerber commented 1 year ago

@bertsky I agree (tentatively, as I have not yet made myself familiar with it, but it sure looks like the best solution)

mikegerber commented 1 year ago

We already do this (the testing of Python 3.6 to 3.10), I just forgot about it :-)

mikegerber commented 1 year ago

Python 3.11 does not work currently and I don't think I'll investigate further until we can update to Calamari 2. (→ #77)

mikegerber commented 1 year ago

(Moved comment to #72)

mikegerber commented 1 year ago

Closing as this is already done and for the other stuff we have #72.