OCR-D / ocrd_fileformat

OCR-D wrapper for ocr-fileformat

Apache License 2.0

4 stars 3 forks source link

[app][fix] skip add fileRef on exception #13

Closed M3ssman closed 4 years ago

M3ssman commented 4 years ago

Sorry for the inconvenience, but I need a fix for https://github.com/OCR-D/ocrd_fileformat/issues/10 ASAP ...

M3ssman commented 4 years ago

@kba I did a quick check right now, updating ocr-fileformat submodule to 61d336e5ddfa73c773a3c37bb563d86b2252b52a, which has the change included. It still prints the stacktrace in case of an exception and therefore the numerical comparisation doesn't work.

The Exception is thrown in case there was no text content found. This can happen anytime for covers, blank pages, illustrations, etc...

M3ssman commented 4 years ago

But something else: I'd like to turn off bash debugging, since it fills the logs. If one is really interested in running a script in debug, it could be done straight at call time.

kba commented 4 years ago

14 is now released as v0.0.5, @M3ssman can you have a look and check whether this adresses all issues raised in this PR?

M3ssman commented 4 years ago

Yes, looks good to me.