OCR-D / ocrd_froc

Apache License 2.0
7 stars 2 forks source link

Add docker build target and introduce pyprojct.toml #18

Closed joschrew closed 1 month ago

joschrew commented 1 month ago

The main purpose of this PR is to provide a Dockerfile and a makefile target/task to build the image for this processor. Also I switched from setup.py to pyproject.toml. The so far used setup.py was not working for me to successfully install the processor in the dockerimage. I also "just" added the Apache License, because ocrd-core uses the same. I saw that many processors use MIT license, maybe that is better to use? I think the dependencies from requirements.txt all have BSD License so are compatible with Apache 2 License. So from my point of view this should fit but other than that I have no idea if it is a good idea to add the license. Maybe that should be done in a separate step but maybe this can be done in one go here too.

This is a draft for now because I am not sure about the license. Other than that I have tested the froc-dockerfile and the installation with pyproject.toml and it is working for me, so ready to be merged in this regards.