search

OCR-D / ocrd_kraken

Wrapper for the kraken OCR engine
Apache License 2.0
11 stars 6 forks source link

Add docker arg for base image and change labels #45

Closed joschrew closed 1 month ago

joschrew commented 1 month ago

This adds an argument for the baseimage to the Dockerfile and changes the docker target in the Makefile accordingly. Like it was done for the other processors.

I am not sure about the labels. Here many labels were available, other what we have for the other processors, were only 4 labels are set. I simply removed all the labels to make it consistent (exect the usual 4 labels) . But I am not sure if this is right so maybe this has to be changed again. Therefore this is only a draft yet.

bertsky commented 1 month ago

GHA CI failures: we would need to cherry-pick https://github.com/OCR-D/ocrd_kraken/pull/44/commits/a8a859bf7ee52eadfc6aec0e5e03a84eb1f8945c from #44, or just ignore this – I lean towards the letter.

bertsky commented 1 month ago

Are you waiting for @kba's review, can we undraft?