Closed bertsky closed 1 month ago
So deploy-pypi of course can only work from upstream (due to the credentials), not from forks. The same is true for deploy-docker. Hence the last 3 commits:
ghcr.io/bertsky/ocrd_tesserocr
), so this job can always run on masterdeploy
jobs (deploy-pypi and deploy-docker for Dockerhub) on forksI now believe this is the right approach – and we should adopt this for other OCR-D repos, too.
(But running python -m build .
inside our own Docker image should not be necessary in most other cases, as these do not have heavy non-Python dependencies.)
Not sure if there is a better way. We cannot use our own Docker image in Github Actions, but in CircleCI we can. (Without that image, I am not sure if the build could succeed without first installing Tesseract and tesserocr.)