search

OCR-D / ocrd_tesserocr

Run tesseract with the tesserocr bindings with @OCR-D's interfaces
MIT License
38 stars 11 forks source link

Use common functionalities from "ocrd-utils" #49

Closed wrznr closed 5 years ago

wrznr commented 5 years ago

As soon as they are available, the common functionalities from core should be employed.

bertsky commented 5 years ago

Right, we should move common into core, but the image functions all depend on the workspace instance, so I think ocrd.workspace.Workspace would be the best place for them. (The coordinate conversion functions should of course go to ocrd_utils.)

kba commented 5 years ago

Most of the ocrd_* modules have their own utils modules that are too specific for ocrd_utils.

For the image_from_* functions, it would indeed make most sense to have them in workspace as you proposed.

bertsky commented 5 years ago

Splendid. Just note, I will add a PR in ocrd_tesserocr which will rebase everything in common on true polygons (and masking instead of cropping). We should wait for that version in core.

kba commented 5 years ago

Has been implemented as of https://github.com/OCR-D/ocrd_tesserocr/pull/66