OCR-D / quiver-frontend

Apache License 2.0
0 stars 1 forks source link

Quiver timeline, diachronic view - enlarge diagram on demand (for a more detailed view) #44

Closed MareenGeestmann closed 5 months ago

MareenGeestmann commented 11 months ago

Enable to enlarge diagram on demand (for a more detailed view).

New details:

Note: Labels must be shown when plot is enlarged, but can be ommitted when in preview (for a cleaner look as many charts are shown).

Please enlarge font size of axis values.

MareenGeestmann commented 11 months ago

Please add x-axis label ("release date"). It is not self-explaning what date it is. Please add units to metric. Please add document name to title.

In some metrices y-labels are overlapping with axis-values. Was the font size of the axis values increased? (if yes, even larger would be more legible)

paulpestov commented 11 months ago

Please add x-axis label ("release date"). It is not self-explaning what date it is.

The x-axis is just time, it is not a release date. Release date are now marked as dashed lines within the chart.

Please add document name to title.

The document name apprears to be often quite long and is also visible in the timeline item. I think the connection to the document should be clear when the user opens several detail charts within one timeline item. So I thought the workflow name should be enough.

Was the font size of the axis values increased? (if yes, even larger would be more legible)

Yes, it is 11px. Larger font size will have negative effect on readability for the dates on the x-axis.

For the rest, fixes incoming.

MareenGeestmann commented 11 months ago

Image

To which document does the plot belong? (through the eye of a naive user) When the title is too long, then we should use a visual cue.

Please remind me, what do the data points mean? => ocrd_all releases + manually triggered runs (for development purposes)

The release data markers are nice.

MareenGeestmann commented 11 months ago

To sum up, open tasks:

noornoorie commented 8 months ago

@MareenGeestmann I've open a pull request #66 where I've added x-axis title and document name title. However, I'm not sure about the metric units since we don't have them in API response. What should I do in this regard? Should I hardcode them? If so, what would be the units for each metrics?

MareenGeestmann commented 8 months ago

For documentation purposes, as discussed:

noornoorie commented 7 months ago

@MareenGeestmann Should I hardcode the units into the code or would those be provided by backend api?

MareenGeestmann commented 7 months ago

I cannot say if they were provided by the API. @paulpestov Do you know it? If not provided it seems necessary to hardcode it.

paulpestov commented 7 months ago

Yes, for now we can hardcode them.