Closed jfrer closed 3 months ago
The code itself looks fine, but there a some accessibility concerns:
I would suggest to check with the WAVE browser extension.
Also, lots of Vue warnings are logged to the console about missing props, extraneous non-props attributes and missing translations. This should be investigated.
The code itself looks fine, but there a some accessibility concerns:
- All controls should be labelled, and while the checkbox for toggling all filters has an ARIA attribute, a label legible by everyone would not hurt.
- There are many contrast errors, but only few of those have been introduced by this PR.
I would suggest to check with the WAVE browser extension.
Also, lots of Vue warnings are logged to the console about missing props, extraneous non-props attributes and missing translations. This should be investigated.
Thanks for the extensive review.
I added a label to the checkbox for toggling all filters in 9639690. As there is no native functionality/slot for this in the PrimeVue component we use, I had to implement it manually. In this move I implemented a wrapper component to avoid/reduce code duplication.
The WAVE Tool seems very nice, but I can't find contrast errors that have been introduced by this PR. Can you specify where you found these? I will resolve the rest of the contrast errors in a seperate PR.
I also noticed the Vue warnings when I started this project a month ago and got so annoyed by the amount of warnings that I deselected the warnings filter in the console. 😅 I will also try to fix them in a seperate PR.
The WAVE Tool seems very nice, but I can't find contrast errors that have been introduced by this PR. Can you specify where you found these?
Selected items in the dropdowns have a contrast ratio of 2.55 or lower, while WCAG AA requires at least 4.5 for normal-sized text. In general, the blue is too light, especially on a colored background.
Selected items in the dropdowns have a contrast ratio of 2.55 or lower, while WCAG AA requires at least 4.5 for normal-sized text. In general, the blue is too light, especially on a colored background.
Ah, thanks, I see. As we didn't put much thought into coloring yet, these are just default color stylings from the lara-light-blue
theme. I will change the theme to a more accessible one when I will work on #91, because I think that a color theme change is a little bit out of scope of this PR. For now, I made the coloring of the "Select all"-Label a variable that will change with the theming.
closes #68