OCR-D / quiver-frontend

Apache License 2.0
0 stars 1 forks source link

feat: add filters for gt labelling and gt script-type #88

Closed jfrer closed 3 months ago

jfrer commented 4 months ago

closes #68

t11r commented 3 months ago

The code itself looks fine, but there a some accessibility concerns:

I would suggest to check with the WAVE browser extension.

Also, lots of Vue warnings are logged to the console about missing props, extraneous non-props attributes and missing translations. This should be investigated.

jfrer commented 3 months ago

The code itself looks fine, but there a some accessibility concerns:

  • All controls should be labelled, and while the checkbox for toggling all filters has an ARIA attribute, a label legible by everyone would not hurt.
  • There are many contrast errors, but only few of those have been introduced by this PR.

I would suggest to check with the WAVE browser extension.

Also, lots of Vue warnings are logged to the console about missing props, extraneous non-props attributes and missing translations. This should be investigated.

Thanks for the extensive review.

t11r commented 3 months ago

The WAVE Tool seems very nice, but I can't find contrast errors that have been introduced by this PR. Can you specify where you found these?

Selected items in the dropdowns have a contrast ratio of 2.55 or lower, while WCAG AA requires at least 4.5 for normal-sized text. In general, the blue is too light, especially on a colored background.

jfrer commented 3 months ago

Selected items in the dropdowns have a contrast ratio of 2.55 or lower, while WCAG AA requires at least 4.5 for normal-sized text. In general, the blue is too light, especially on a colored background.

Ah, thanks, I see. As we didn't put much thought into coloring yet, these are just default color stylings from the lara-light-blue theme. I will change the theme to a more accessible one when I will work on #91, because I think that a color theme change is a little bit out of scope of this PR. For now, I made the coloring of the "Select all"-Label a variable that will change with the theming.