OCR4all / LAREX

A semi-automatic open-source tool for Layout Analysis and Region EXtraction on early printed books.
MIT License
179 stars 33 forks source link

fixed missing textline orientation #289

Closed chaddy314 closed 2 years ago

chaddy314 commented 2 years ago

adds missing textline rotation according to angle specified in /PcGts/Page/@orientation fixes #285

bertsky commented 2 years ago

Sry @chaddy314 I cannot test this, because when building and running this branch, I cannot get past the Open Book dialog anymore – regardless of type (METS/flat) or path names. It just stays there, regardless how often I press NEXT. There's nothing on stdout/stderr either. So I don't even know how to report this regression. (I assume it could be related to https://github.com/OCR4all/LAREX/commit/7cc061318bfe31828df809c4b9085d7f7a154353, which I have not yet tested either.)

bertsky commented 2 years ago

I cannot test this, because when building and running this branch, I cannot get past the Open Book dialog anymore – regardless of type (METS/flat) or path names. It just stays there, regardless how often I press NEXT. There's nothing on stdout/stderr either

I don't know what I did wrong last time, but after rebuilding, everything works now – including the unrotated textline polygons. Thank you very much!

bertsky commented 2 years ago

I cannot get past the Open Book dialog anymore – regardless of type (METS/flat) or path names. It just stays there, regardless how often I press NEXT. There's nothing on stdout/stderr either.

Wait: the problem does persist, and I do see it on stderr:

org.springframework.web.servlet.handler.AbstractHandlerExceptionResolver.resolveException Resolved [org.springframework.web.bind.MissingServletRequestParameterException: Required String parameter 'fileMap' is not present]
bertsky commented 2 years ago

Documented the latter point (which is unrelated to this issue – sorry) here.

This is ready for merging if you'd ask me.

bertsky commented 2 years ago

@chaddy314 sorry for bringing this up so late, but could it be that baselines are still missing from unrotateSegments?

chaddy314 commented 2 years ago

Unfortunately, yes. Fix will be up as soon as possible.