search

OCSInventory-NG / OCSInventory-Docker-Image

Docker image for OCSInventory Server
GNU General Public License v3.0
77 stars 90 forks source link

2.9 docker-entrypoint.sh is not complete #80

Closed rikasobe closed 2 years ago

rikasobe commented 2 years ago

It's hard to solve a problem when important details are missing, that why we added this template, to help you and us.

General informations

Docker host's operating system : Mysql Server version :

Docker informations

Docker compose version : Docker version :

Problem's description

Describe your problem here we have problem with start a docker in tag 2.9, when we review this document /OCSInventory-NG/OCSInventory-Docker-Image/tree/master/2.9)/scripts/docker-entrypoint.sh, it dont have a command for start httpd.

/usr/sbin/httpd -DFOREGROUND

regards

wiltonsr commented 2 years ago

Hi @rikasobe

The docker-entrypoint.sh script follows a Docker's best practice to have an ENTRYPOINT and a default CMD that work together and permit the user to override default container initialization.

You can see the httpd start commando in Dockerfile. https://github.com/OCSInventory-NG/OCSInventory-Docker-Image/blob/2b6013841c1634368bb854ae80d33b5b6928d9bf/2.9/Dockerfile#L90-L91

The docker-entrypoint.sh script has a bash notation exec "$@" https://github.com/OCSInventory-NG/OCSInventory-Docker-Image/blob/2b6013841c1634368bb854ae80d33b5b6928d9bf/2.9/scripts/docker-entrypoint.sh#L175 that, quoting from this stackoverflow's answer:

It basically takes any command line arguments passed to entrypoint.sh and execs them as a command. The intention is basically "Do everything in this .sh script, then in the same shell run the command the user passes in on the command line".

Regards.

wiltonsr commented 2 years ago

@gillesdubois @charleneauger

This issue should be closed.

gillesdubois commented 2 years ago

Hi,

Indeed, I'll close the issue :)

Thx. Gilles.