Hi Amy, I am not sure exactly if we need to be compatible with multiple versions of FHIR. I think it is fine if we can basically meet the requirements of Vulcan. But the README should indicate if we ONLY support version 5.
Hi Peter. This library doesn't actually talk to any servers, so the upgrade in this pull request is really about making sure that the Observations passed in are structurally compatible for R5. In general it is easier to "upgrade" an Observation than to downgrade it. The SMART on FHIR app using this library might communicate with an earlier versioned FHIR server. If so, it takes on the job of upgrading the Observation structure to R5 in order to use this library and convert the Observation to HPO. We could certainly support other FHIR versions directly in this library, but I prefer to leave that to the consumer with conversion being a relatively straightforward exercise using the HAPI libraries.
Hi Peter. This library doesn't actually talk to any servers, so the upgrade in this pull request is really about making sure that the Observations passed in are structurally compatible for R5. In general it is easier to "upgrade" an Observation than to downgrade it. The SMART on FHIR app using this library might communicate with an earlier versioned FHIR server. If so, it takes on the job of upgrading the Observation structure to R5 in order to use this library and convert the Observation to HPO. We could certainly support other FHIR versions directly in this library, but I prefer to leave that to the consumer with conversion being a relatively straightforward exercise using the HAPI libraries.