OCamlPro / alt-ergo

OCamlPro public development repository for Alt-Ergo
https://alt-ergo.ocamlpro.com/
Other
132 stars 33 forks source link

fix(CI): Ensure binary releases have proper version number #1171

Closed bclement-ocp closed 4 months ago

bclement-ocp commented 4 months ago

The issue boils down to GitHub not downloading tag information when running the workflow, which means that dune-build-info and dune-subst see a lightweight tag rather than an annotated tag and ignore it.

In order to facilitate deployment, update the workflow to automatically upload the artifact to the release if applicable.

Fixes #1131

bclement-ocp commented 4 months ago

Do I need to wait for #1169 before merging?

Halbaroth commented 4 months ago

Alas, yes... I am struggling with github permissions :/