Closed lefessan closed 1 year ago
I added -ftversion
to avoid escaping problems with the space in the title in atlocal.in
...
I still have many tests in listing.at
to modify...
Just stumbled over that: one of the listing tests has 2x identical prog.cob with PROCEDURE DIVISION USING PAR-IN RETURNING PAR-OUT.
- if possible please drop the second AT_DATA when adjusting listing.at
Merging #105 (afeb5ca) into gcos4gnucobol-3.x (4b8452a) will increase coverage by
0.01%
. The diff coverage is92.85%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## gcos4gnucobol-3.x #105 +/- ##
=====================================================
+ Coverage 65.17% 65.19% +0.01%
=====================================================
Files 31 31
Lines 58384 58393 +9
Branches 15380 15384 +4
=====================================================
+ Hits 38051 38067 +16
+ Misses 14402 14396 -6
+ Partials 5931 5930 -1
Impacted Files | Coverage Δ | |
---|---|---|
cobc/cobc.c | 71.53% <88.88%> (+0.25%) |
:arrow_up: |
cobc/flag.def | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Just stumbled over that: one of the listing tests has 2x identical prog.cob with
PROCEDURE DIVISION USING PAR-IN RETURNING PAR-OUT.
- if possible please drop the second AT_DATA when adjusting listing.at
I think I found it and removed it.
Argh, tests run fine with autofonce
but not with autotest
, I need to investigate the different behavior...
Argh, tests run fine with
autofonce
but not withautotest
, I need to investigate the different behavior...
Just inspected the testsuite.log: it is exactly as I've thought:
-GnuCOBOL V.R.P prog.cob
+GnuCOBOL V.R.P prog.cob
To fix that change the place where cb_listing_with_timestamp
is checked (should be in print_program_header()
) and the tests will pass. Note that this directly allows to give either the title or the filename more space, too.
I will commit this version to SVN as soon as the CI passes, to be able to switch to the other PR.
There are still tests with spaces at the end of headers, that I fixed using a quadrigraph (@&t@
) to prevent autoconf from removing them. I preferred not to change the printing because the spaces are generated by %-26.26s
in printf
and I was not sure of the intention.
( I just pushed a commit in autofonce
to correctly handle spaces, in case you use it)
I preferred not to change the printing because the spaces are generated by
%-26.26s
inprintf
and I was not sure of the intention.
The point was that there is a trailing timestamp, right adjusted.
If -fno-ttimestamp
is used we currently printf the low-value; but when this is changed to not adjustt the timestamp var but instead adjust the printing and right-justify the sourcename, then we should not have any trailing spaces left.
LGTM (we can right-adjust the filename for -fno-ttimestamp
later)
Merged with whitespaces removed at the end of line
follow-up to the discussion originally in https://github.com/OCamlPro/gnucobol/pull/75, implementing part of https://sourceforge.net/p/gnucobol/feature-requests/294/
New flags: