OCamlPro / gnucobol

A clone of the sourceforge GnuCOBOL compiler from COBOL to C.
https://get-superbol.com
GNU Lesser General Public License v3.0
16 stars 20 forks source link

Fix cob_call_with_exception_check (test 771) #129

Closed ddeclerck closed 6 months ago

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c0d64ad) 65.74% compared to head (52f4cb5) 65.74%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## gcos4gnucobol-3.x #129 +/- ## ================================================== Coverage 65.74% 65.74% ================================================== Files 32 32 Lines 59092 59096 +4 Branches 15575 15576 +1 ================================================== + Hits 38849 38854 +5 Misses 14262 14262 + Partials 5981 5980 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ddeclerck commented 7 months ago

Is there a reason to skip the complete termination?

Well, in #125, you suggest :

I'd prefer the second - and document that modules will only be unloaded with this function if after the call a manual call to cob_tidy() is done.

Since cob_tidy calls call_exit_handlers_and_terminate, it seemed natural to just skip the whole termination.

Anyways, I pushed an improved version, where only the last bits of termination are delayed, ie only the following calls :

    cob_exit_call ();
    cob_exit_common ();

Cleanup is automatically performed after the longjump, so no need to call cob_tidy.