OCamlPro / gnucobol

A clone of the sourceforge GnuCOBOL compiler from COBOL to C.
https://get-superbol.com
GNU Lesser General Public License v3.0
16 stars 20 forks source link

Fix of screen section clauses #135

Closed engboris closed 4 months ago

engboris commented 5 months ago

Fix for bug #947 on Sourceforge

The VALUE ALL '-' clause in SCREEN SECTION did not work (error message error: syntax error, unexpected ALL) although it should have.

Screen sections used clauses with basic_literal which does not allow the ALL keyword. I remplaced it by the literal construction (already defined) which extends basic_literal with the ALL keyword.

I added a test in testsuite/syn_screen.at (at the end) based on the code provided in the bug report.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2ff35a3) 65.74% compared to head (37eae71) 65.78%. Report is 4 commits behind head on gcos4gnucobol-3.x.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## gcos4gnucobol-3.x #135 +/- ## ===================================================== + Coverage 65.74% 65.78% +0.03% ===================================================== Files 32 32 Lines 59380 59416 +36 Branches 15683 15694 +11 ===================================================== + Hits 39040 39086 +46 + Misses 14326 14312 -14 - Partials 6014 6018 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

engboris commented 5 months ago

I believe so. The test displays a sequence of "-" symbols and that's what I get.

engboris commented 5 months ago

I believe it should have a "Ready for SVN" label?

ddeclerck commented 4 months ago

Merged in SVN at revision 5226. (@GitMensch Can you reattribute this to user "engboris" ?)

GitMensch commented 4 months ago

Thanks for the check-in; metadata was updated in svn and bug ticket closed