search

OCamlPro / gnucobol

A clone of the sourceforge GnuCOBOL compiler from COBOL to C.
https://get-superbol.com
GNU Lesser General Public License v3.0
22 stars 24 forks source link

ChangeLog and testsuite adjustments #178

Closed ddeclerck closed 2 months ago

ddeclerck commented 2 months ago

As requested here and here.

Also it seems at some point recently some changes broke the CI - I'll investigate and update this PR.

GitMensch commented 2 months ago

the test looks good, but it seems something is indeed broken in the parser ?!?

ddeclerck commented 2 months ago

the test looks good, but it seems something is indeed broken in the parser ?!?

Yeah but this is unrelated to the conflicts mentionned in the GC3-GC4 merge PR. It seems USAGE PROGRAM-POINTER with a program-prototype argument has never been parsed correctly.

GitMensch commented 2 months ago

Are you working on this?

ddeclerck commented 2 months ago

Are you working on this?

I'd rather postpone this issue for now for I fear it would take me too far away from the GC3-GC4 merge (plus I'm already being taken away by PR 109).

GitMensch commented 2 months ago

Make it an expected failure then and commit upstream, but don't merge it yet - just verify manually that the result with your GC4merge is not worse.

ddeclerck commented 2 months ago

Make it an expected failure then and commit upstream, but don't merge it yet - just verify manually that the result with your GC4merge is not worse.

Maybe I can split the 3 cases POINTER/FUNCTION-POINTER/PROGRAM-POINTER so that we can at least "protect" what already works ?

GitMensch commented 2 months ago

Good idea. Possibly with a comment to combine again later. Can directly go upstream.

ddeclerck commented 2 months ago

Also includes fixups for recently introduced CI failures (there were a C++-style comment in scanner.l and missing stdio.h includes both in scanner.l and pplex.l).

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.55%. Comparing base (8b7350a) to head (8d1ba62). Report is 30 commits behind head on gcos4gnucobol-3.x.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## gcos4gnucobol-3.x #178 +/- ## ====================================================== + Coverage 66.15% 77.55% +11.39% ====================================================== Files 33 33 Lines 60257 60230 -27 Branches 15833 15834 +1 ====================================================== + Hits 39863 46709 +6846 + Misses 14333 13521 -812 + Partials 6061 0 -6061 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.