search

OCamlPro / gnucobol

A clone of the sourceforge GnuCOBOL compiler from COBOL to C.
https://get-superbol.com
GNU Lesser General Public License v3.0
22 stars 24 forks source link

Add optional index check in 3.x #191

Open ddeclerck opened 1 month ago

ddeclerck commented 1 month ago

This PR attemps to backport SVN commit 4953 4954 & 5358 to 3.x.

ddeclerck commented 1 month ago

Actually I'm not very confident I could do that quickly enough. I'd rather delegate this so I could focus on the GC3/GC4 merge - the clock's ticking and the days allocated to this task are almost depleted.

GitMensch commented 1 month ago

I was surprised you took on that backport. The issue that I've now realized is - if you want to merge the dialect option from GC3 to GC4 then this has to be done in any case :-/

ddeclerck commented 1 month ago

I was surprised you took on that backport. The issue that I've now realized is - if you want to merge the dialect option from GC3 to GC4 then this has to be done in any case :-/

True indeed ; that dialect option is commit 5087 (so this will be a problem in ~50 commits). Though I'm just realizing now that feature was implemented by Nicolas ; I'm gonna ask him for help.

GitMensch commented 1 month ago

MSVC CI should be fixed with updating from upstream (I've worked on that before my vacation).

Apart from that: What is the state of this PR?

ddeclerck commented 1 month ago

Apart from that: What is the state of this PR?

I'd stay "stale" - waiting for someone else to take over. In the meantime I made PR #194 to (temporarily) disable that check in GC4 so that I could continue the merge (as discussed in https://github.com/OCamlPro/gnucobol/pull/147#issuecomment-2405586694).