OCamlPro / gnucobol

A clone of the sourceforge GnuCOBOL compiler from COBOL to C.
https://get-superbol.com
GNU Lesser General Public License v3.0
16 stars 21 forks source link

[GCOS] Add STOP ERROR statement #36

Closed ddeclerck closed 2 years ago

GitMensch commented 2 years ago

runtime test is missing, otherwise looks good so far

ddeclerck commented 2 years ago

please move stop-error-statement in config.def (and therefore also in testsuite.src/used_binaries.at) and config/* directly after stop-identifier-statement.

Done. By the way, should the .conf files follow this order too ?

GitMensch commented 2 years ago

They can use a different order than config.def and may do; but this one should be moved.

config/* directly after stop-identifier-statement

:-)

nberth commented 2 years ago

(Marked as WIP as awaiting a rebase w.r.t gcos4gnucobol-3.x)

GitMensch commented 2 years ago

@lefessan @ddeclerck: What do you think of adding this to gnucobol-3.x in sourceforge after adjusting the last missing piece and without the actual gcos config? Or should we wait until this is in (and who wants to add that)? Just the config + word list + help.c + testsuite.src should be a reasonable start commit for GCOS, then this could come in directly next.

Note: The actual coredump request noted in the GCOS manual for this is configurable, soon - runtime errors will then raise an abort which is passed to the OS which will then coredump.

nberth commented 2 years ago

@ddeclerck could you update this PR based on https://github.com/nberth/gnucobol/tree/stop_error so that the diff can be extracted directly for upstreaming? Thanks!

nberth commented 2 years ago

Hi @GitMensch , This PR has just been rebased against the upstream versions of GCOS config files. I can commit to the svn if you think it's ok.

GitMensch commented 2 years ago

reviewed and ready to be checked in upstream

nberth commented 2 years ago

Should be upstream now.