search

OCamlPro / ocp-index

Easy access to the interface information of installed OCaml libraries for editors like Emacs and Vim.
http://www.typerex.org/ocp-index.html
Other
62 stars 25 forks source link

Fix the preprocessing actions #128

Closed ghost closed 5 years ago

ghost commented 5 years ago

Preprocessing actions shouldn't manually redirect the output to ${@} as dune already does this. This used to work, however it no longer works with dune >= 1.6.3 (see ocaml/dune#1811 for details).

We plan to make this a hard error in dune, to avoid other cases in the future.

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

ghost commented 5 years ago

Do I need to sign a CLA for this patch? It is very small and trivial...

AltGr commented 5 years ago

You can ignore the CLA ;) We should probably update the opam file to specify the minimum version of dune though ? (The dependency is still to jbuilder)

Drup commented 5 years ago

@AltGr We could just upgrade to dune on the way and ditch jbuilder couldn't we ?

ghost commented 5 years ago

Before this patch there should be a conflict with dune >= 1.6.3, but after this patch the conflict is no longer needed, i.e. the new code works with both old and new versions of dune. So we should update the opam file in the opam-repository, but it is not necessary to update the one in this repository.

Regarding moving to dune, we now have an automatic upgrader in dune master; running dune upgrade will convert the project to dune (except for the calls to jbuilder in the Makefile).

AltGr commented 5 years ago

great, thanks!

Drup commented 5 years ago

Let's merge, so that we can at least pin master! :)

UnixJunkie commented 5 years ago

There should be a bugfix release also. Thanks!