search

OCamlPro / ocp-index

Easy access to the interface information of installed OCaml libraries for editors like Emacs and Vim.
http://www.typerex.org/ocp-index.html
Other
62 stars 25 forks source link

Add support for OCaml 4.12 #145

Closed kit-ty-kate closed 3 years ago

kit-ty-kate commented 4 years ago

Equivalence between (true, true) and (NoVariance, NoInjectivity) can be found in this commit: https://github.com/ocaml/ocaml/commit/603506aa34d0e5f7a9745c988777776ccb734094

Drup commented 4 years ago

We need to do something about CI ._.

The patch looks good. @AltGr ?

kit-ty-kate commented 3 years ago

https://github.com/OCamlPro/ocp-index/commit/a4d9a2e22a511eeba08b769411b1304679151909 broke ocp-browser on OCaml 4.12, I fixed that in ecc36c7 and added OCaml up to 4.12 in CI.

kit-ty-kate commented 3 years ago

Ultimately I suggest you to switch to github actions but this can wait and as far as I know it's nothing I can do on my own as a contributor AFAIK.

kit-ty-kate commented 3 years ago

Could someone with the appropriate rights enable Github Actions?

kit-ty-kate commented 3 years ago

Github Actions apparently can't be enabled via a PR. So it should be enabled automatically once this PR is merged. Here is the CI result from this run: https://github.com/kit-ty-kate/ocp-index/actions/runs/559595363

Everything is green so this should be good to go.

AltGr commented 3 years ago

Thanks!

kit-ty-kate commented 3 years ago

would it be possible to have a release whenever one of you two have some time?