ODINN-SciML / DiffEqSensitivity-Review

A Review of Sensitivity Methods for Differential Equations
MIT License
29 stars 14 forks source link

fix: t_i to t_n for consistency #104

Closed olivierbonte closed 5 months ago

olivierbonte commented 5 months ago

If I understand correctly, throughout the text \Delta t_n is used throughout, with the exception of the 2 uses of \Delta t_i here. Therefore I changed it for consistency.

facusapienza21 commented 5 months ago

Thank you @olivierbonte for the PR. We had changed this section in the updated version of the review paper, which you can find in my fork. Sorry we haven't yet updated the main repository with this modifications.

We hope to have a final pre-print ready very soon. Feel free to reach out to me directly if you have any further question or comment!

olivierbonte commented 5 months ago

Okay great that it was already fixed in your fork!

Have definitely found the preprint to be super useful thus far :) I hope to apply Universal Differential Equations to (eco)hydrological problems during my PhD and found it hard to make sense of the different methods until I found your work, so also a big thanks to @JordiBolibar for pointing me to the preprint during our chat at EGU24.

JordiBolibar commented 5 months ago

Thanks @olivierbonte! Happy to hear that it's useful :)

JordiBolibar commented 5 months ago

Thanks @olivierbonte! Happy to hear that it's useful :)