Expensive for-loops should be rewritten/removed

ODINN-SciML / MassBalanceMachine

Global machine learning glacier mass balance model, capable of assimilating all sources of glaciological and remote sensing data

MIT License

17 stars 11 forks source link

Expensive for-loops should be rewritten/removed #8

Closed JulianBiesheuvel closed 4 months ago

JulianBiesheuvel commented 5 months ago

In the custom loss function, for example, the for-loop should be rewritten/removed by more efficient code. Options are vectorizing, or adding @jit for Numba usage.

JulianBiesheuvel commented 4 months ago

Done. But now .appy and .groupby are used. Especially apply can still be a performance bottleneck. It is worth looking into using Numba or similar in the future. A new issue will be made for this with a low priority, see issue #39.