search

ODM2 / CZ-Manager

CZ Manager (formerly ODM2 Admin) is an application for site level data management of environmental observations using Observation Data Model 2 (ODM2) for documentation and a detailed walkthrough see:
http://odm2.github.io/CZ-Manager
MIT License
9 stars 12 forks source link

doc update test #190

Closed miguelcleon closed 6 years ago

miguelcleon commented 6 years ago

last PR failed on travis. It seems like that shouldn't have happened as it only contained doc updates

miguelcleon commented 6 years ago

@lsetiawan any idea why this is failing travis? It seemed like maybe it has to do with tests, but that doesn't seem to be the case.

miguelcleon commented 6 years ago

@lsetiawan I'm writing some tests just in case that might fix it. It is difficult to imagine writing all of the tests that it might be a good idea to have. There are just so many.

lsetiawan commented 6 years ago

I've restarted the job, it was a giving a file not found error, but it doesn't say what file.

miguelcleon commented 6 years ago

@lsetiawan ok, it has continued to do this 4th or 5th time so far, the only thing I changed in all of those cases were the documentation.

lsetiawan commented 6 years ago

@ocefpaf any idea why this is failing? The error we get is:

ERROR: file not found: discover

miguelcleon commented 6 years ago

@ocefpaf I added a test because it looks like it might be a problem with test discovery? I don't know but it seemed like it would be worth trying here is the branch that failed https://travis-ci.org/ODM2/ODM2-Admin/builds/312503780?utm_source=github_status&utm_medium=notification

miguelcleon commented 6 years ago

still failed and it didn't run the test.

miguelcleon commented 6 years ago

I moved the test I added which works locally but it still did not run on Travis and it exited with the same error.

ocefpaf commented 6 years ago

@miguelcleon and @lsetiawan the testing framework here was design for a installable package. Because #102 was never accepted we need to change the logic. See https://github.com/ODM2/ODM2-Admin/pull/191

Note that #191 will fail b/c we must configure the django app before running the tests. I'll leave that to the django experts :wink:

miguelcleon commented 6 years ago

is my .travis.yml file wrong?

lsetiawan commented 6 years ago

I think that #191 is the right fix to .travis.yml to make the tests to run. But we do need need to configure the django app.

miguelcleon commented 6 years ago

@lsetiawan ok, in this latest commit, I just changed thematrix: section, I'm not sure what else to change at the moment. I need to work on something else for a little bit.

lsetiawan commented 6 years ago

See https://github.com/ODM2/ODM2-Admin/pull/191/commits/12d37851dae467cb148f0f58bdcb795a547bb02a The matrix: shouldn't need to change.

miguelcleon commented 6 years ago

OK, latest commit attempts to replicate https://github.com/ODM2/ODM2-Admin/pull/191/commits/12d37851dae467cb148f0f58bdcb795a547bb02a maybe it will work

lsetiawan commented 6 years ago

Now the error is OSError: libgeos-3.5.0.so: cannot open shared object file: No such file or directory Seems to be a problem with gdal.

miguelcleon commented 6 years ago

The import line it is failing is from models.py line 16: from django.contrib.gis.db import models as gis_models

miguelcleon commented 6 years ago

that is also the first django import line. I'm going to try moving it, to see if the next import also errors.

lsetiawan commented 6 years ago

Gimme a sec, lemme try this out locally.

miguelcleon commented 6 years ago

ok

miguelcleon commented 6 years ago

latest commit fails on the below, other django.db and django.core imports worked. from django.contrib.gis.geos import GEOSGeometry

lsetiawan commented 6 years ago

I tried this locally and getting a different error... frustrating. hmm... django.contrib.gis.geos.error.GEOSException: Error encountered checking Geometry returned from GEOS C function "GEOSWKTReader_read_r" I have the same exact packages as in travis.

miguelcleon commented 6 years ago

maybe @ocefpaf has an idea about what else to try?

ocefpaf commented 6 years ago

I'm away from my laptop for a few days but I'll try to take a quick look tomorrow.

On Dec 20, 2017 20:58, "Miguel Leon" notifications@github.com wrote:

maybe @ocefpaf https://github.com/ocefpaf has an idea about what else to try?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ODM2/ODM2-Admin/pull/190#issuecomment-353207430, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6BL3zfZhpGim4D-qa5IXKz8uGx6Eowks5tCZEXgaJpZM4Q4LjC .

ocefpaf commented 6 years ago

@lsetiawan the django version used here is quite and inconsistent with conda-forge's gdal and geos. The options are:

Any those will require some considered effort! My recommendation is to "future proof" the app and go for django 2.0. The second option would be the backport.