search

ODM2 / CZ-Manager

CZ Manager (formerly ODM2 Admin) is an application for site level data management of environmental observations using Observation Data Model 2 (ODM2) for documentation and a detailed walkthrough see:
http://odm2.github.io/CZ-Manager
MIT License
9 stars 12 forks source link

Enhancing the management and exposure of persistent universal identifiers #35

Open lsetiawan opened 8 years ago

lsetiawan commented 8 years ago

Hi @miguelcleon and @emiliom,

I am currently, enhancing ODM2Admin by displaying IGSN in the Sampling Features change list, and allow one to enter IGSN when creating a Sampling Feature. I have also added a feature to display ORCID for a Person and their affiliation. Additionally, one can enter a person's ORCID within the person add form.

I improved the UI a bit for listing editable item types in addition to those enhancements.

You can follow my changes here: link

Here are some screenshots if you're interested: link

Thanks.

miguelcleon commented 8 years ago

Cool, I checked out the screen shoots, looks great. Do a pull request when your ready.

emiliom commented 8 years ago

Thanks, @lsetiawan. @miguelcleon, it'll probably be another week or more before we're ready to do a PR. But my goal is to have these new features in place to demonstrate from a local / laptop instance at the Montreal workshop.

miguelcleon commented 8 years ago

sounds good, l'm looking forward to giving it a try @lsetiawan @emiliom

miguelcleon commented 8 years ago

Hi, how is this coming along? @lsetiawan @emiliom

lsetiawan commented 8 years ago

Hi @miguelcleon, It is coming along great. I'm still doing few tweaks here and there to improve the UI.

emiliom commented 8 years ago

Yup. @lsetiawan is now exposing doi's, ORCID id's and IGSN's in a nice and user-friendly way, as links to the external records. I'll show this in Montreal next week. Don should be able to submit a PR next wee, once the code stabilizes and we're less focused on entering the cross-CZO sampling information (for the meeting), thinking through UI implications, etc.

miguelcleon commented 8 years ago

Thinking about doing a PR today? @lsetiawan

emiliom commented 8 years ago

@miguelcleon, I've asked @lsetiawan to hold off until after the workshop. Mostly, b/c I need his time! At the workshop, you and I can chat about the changes Don has made and discussions we've had; I can show them to you on my laptop. Then after coordinating with Don, he can do a PR after Wednesday. Sound good?

miguelcleon commented 8 years ago

ok

miguelcleon commented 8 years ago

@emiliom can @lsetiawan issue the PR now I'd really like to see those changes you should role into the site. Thanks!

emiliom commented 8 years ago

@lsetiawan was getting set to do that today, but we weren't able to touch base on this today. We'll discuss tomorrow (Tue), and hopefully he'll be able to follow up with a PR or more soon after.

In the meantime, if you're really curious, all his changes are on his fork, on the crossczo branch. At least changes through last Wednesday, which include everything I told you about or showed at the workshop.

miguelcleon commented 8 years ago

Yeah I was thinking about that, I'd prefer a PR, showing the site again on Wednesday morning so I might pull from it but I don't want to if it's not ready.

emiliom commented 8 years ago

Got it. I have no clue how much extra work it'll be for Don to create the PR(s) after he and I talk tomorrow. But hopefully it won't be a big deal, and he'll be able to submit by your mid afternoon, maybe earlier.

miguelcleon commented 8 years ago

Hopefully shouldn't be a big deal. Thanks!

emiliom commented 8 years ago

Don and I discussed the PR an hour ago. He will submit it very soon, if he hasn't done so already. His availability to answer questions this week may be limited, but from what he tells me, the PR has few or no conflicts relative to your master branch, so hopefully you'll be able to merge easily.