search

ODM2 / ODM2DataSharingPortal

A Python-Django web application enabling users to upload, share, and display data from their environmental monitoring sites via the app's ODM2 database. Data can either be automatically streamed from Internet of Things (IoT) devices, manually uploaded via CSV files, or manually entered into forms.
BSD 3-Clause "New" or "Revised" License
31 stars 8 forks source link

TSV: Plot data is not re-ranging when date range is changed #583

Closed SRGDamia1 closed 2 years ago

SRGDamia1 commented 2 years ago

On staging right now, changing the date range and hitting "Update plot" or selecting last year/month and hitting update plot does not update the data displayed. The date tick mark changes, but the data itself does not. Could this have been broken in the effort to fix #566 ?

SRGDamia1 commented 2 years ago

This might be related to #588

ptomasula commented 2 years ago

Thanks @SRGDamia1, I think this is at least in part related I bug I found with our new class from managing the dynamic loading of timeseries. In commit 0c2d21b I fixed an issue with how that class handled null datetimes, which would prevent that class from actually loading in more data.

You're also correct that #588, is part of the problem here. If no data for the timeseries exists for the date range, then no plot line will be displayed. I think we use issue #588, as a place to resolve challenge. Some type of indication that no data is available for a given timeseries over the current date range makes a lot of sense to me.