search

ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.
http://odm2.github.io/ODM2PythonAPI/
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Use latest Travis-CI image. #109

Closed ocefpaf closed 7 years ago

ocefpaf commented 7 years ago

Closes #88

ocefpaf commented 7 years ago

@lsetiawan can you take a quick look? I removed the Travis-CI image pin b/c that image will be removed soon. I got all the tests to work as expected by removing the unnecessary stuff in the addons and following the same strategy we used in WOFpy.

emiliom commented 7 years ago

I tried a few things and they all failed. I don't really like to pin versions unless we don't have a choice. Without pinning we can catch errors early when something is updated.

I generally agree with this approach regarding software libraries, but in the case of database systems or other such heavy applications (eg, THREDDS), I prefer to pin to specific versions, as @lsetiawan suggested.

ocefpaf commented 7 years ago

I prefer to pin to specific versions

Travis-CI uses Ubuntu Trusty. @lsetiawan do you use Ubuntu? Can you suggest a package name-version for me to try in the .travis.yml?

lsetiawan commented 7 years ago

@lsetiawan do you use Ubuntu? Can you suggest a package name-version for me to try in the .travis.yml?

I do use ubuntu. What ubuntu version does travis use?

ocefpaf commented 7 years ago

They say the latest image is Trusty. See https://docs.travis-ci.com/user/reference/trusty/ Not sure that that means in terms of version :smile:

lsetiawan commented 7 years ago

@ocefpaf try mysql-server-5.6

ocefpaf commented 7 years ago

Will do in a moment. (Switched to Windows to solved something very quickly.)

lsetiawan commented 7 years ago

No rush 😄