search

ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.
http://odm2.github.io/ODM2PythonAPI/
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Sfdataset #121

Closed sreeder closed 7 years ago

sreeder commented 7 years ago

Resolve issue #120. Created a new function getSamplingFeatureDatasets. It returns a DataSetsResults object that has access to both the Datasets object and the Results object

emiliom commented 7 years ago

rename type to dstype

:+1:

lsetiawan commented 7 years ago

@sreeder How come this goes into development branch and not into the master branch?

sreeder commented 7 years ago

@lsetiawan The way we have merged code in the past is: we do our fixes on their own small branches then merge them to development. Then we only merge into master when we are ready to create a new release. So development is the most recent up to date code and the master is stable. Was this workflow changed while I was gone? @horsburgh @emiliom

lsetiawan commented 7 years ago

Ah, interesing. I have not been working that way at all. I merge directly to master after making sure the PR is well tested. I guess we need some clarification to which workflow we should follow.

emiliom commented 7 years ago

This goes back to the back-and-forth about dev workflows we had a couple of weeks ago in the context of yoda-tools.

@lsetiawan, as we discussed last week, for the remainder of this month (and the BiGCZ funding), let's follow the repo maintainer's preferred dev workflow. Which means, eg for odm2api, what @sreeder described; and, eg, or WOFpy and ODM2REST API, the one @lsetiawan described.

lsetiawan commented 7 years ago

@emiliom Sounds good. Thanks for the clarification.