search

ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.
http://odm2.github.io/ODM2PythonAPI/
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Error in DataLoggerFiles and DataLoggerFileColumns #132 #134

Closed lsetiawan closed 6 years ago

lsetiawan commented 6 years ago

Overview

This is the same exact changes by @miguelcleon on PR #133. Just cleaner without the .travis.yml changes.

Notes

From @miguelcleon: see that the first one, this is caused by Dataloggerfiles model, mapping to the wrong column within the database: https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L458.

For the second one, measurementequation is indeed misspelled: https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L514.

also

found two more problems with dataloggerfiles model There is no column dataloggeroutputfiledescription instead it is dataloggerfiledescription https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L460

There is no column dataloggeroutputfilelink instead it is dataloggerfilelink https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L461

lsetiawan commented 6 years ago

Travis CI are now passing. I have approval by @miguelcleon. So I think it is safe to merge.

lsetiawan commented 6 years ago

Merging...