search

ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.
http://odm2.github.io/ODM2PythonAPI/
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Fix builtins #137

Closed lsetiawan closed 6 years ago

lsetiawan commented 6 years ago

Overview

This PR addresses #115. I simply put warnings to avoid breaking the API. All older code that uses the builtin arguments should still work.

emiliom commented 6 years ago

simply put warnings to avoid breaking the API. All older code that uses the builtin arguments should still work.

Very nice scheme!! I really like it, specially how it creates a smooth deprecation path.

I made a suggestion or two. I'll hold off on merging until you've had a chance to follow up.

emiliom commented 6 years ago

I'll merge when the CI is completed.

lsetiawan commented 6 years ago

Thanks @emiliom! :+1: