search

ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.
http://odm2.github.io/ODM2PythonAPI/
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Allow sfid to be None to work with older code #139

Closed lsetiawan closed 6 years ago

lsetiawan commented 6 years ago

Overview

While working on the odm2restapi, I noticed that getResults was returning nothing when sfid is None, so this should fix that and getResults should return all results when sfid is None.

emiliom commented 6 years ago

getResults should return all results when sfid is None

Is this the documented behavior (eg, in the docstring)? It makes sense, but I can't remember. Is this the behavior in the last tagged release (so that the problem got introduced in the dev branch)?

lsetiawan commented 6 years ago

Is this the documented behavior (eg, in the docstring)? It makes sense, but I can't remember. Is this the behavior in the last tagged release (so that the problem got introduced in the dev branch)?

This behavior is documented in docstring. I introduced this when trying to place warnings and removing builtins, so I'm fixing it here. Thanks.

emiliom commented 6 years ago

Ok. Thanks for the clarification. Merging.