Fix SQLite Result ValueDateTime data-type regression bug

ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.

http://odm2.github.io/ODM2PythonAPI/

BSD 3-Clause "New" or "Revised" License

4 stars 13 forks source link

Fix SQLite Result ValueDateTime data-type regression bug #167

Closed emiliom closed 5 years ago

emiliom commented 5 years ago

Fixes #158.

Tested on the timeseries notebook at https://github.com/ODM2/ODM2PythonAPI/blob/master/Examples/TimeSeries_RetrieveVisualize.ipynb

emiliom commented 5 years ago

@aufdenkampe and @horsburgh This PR fixes the SQLite regression bug described in #158.

I usually prefer to have someone else review changes; let me know if you can do it this week, otherwise I'll go ahead and merge on Friday (we'll see also how the CI checks do -- they should be fine). FYI, this PR involves a change to just one line.

This is one of the two must-do elements in my targets for the new release (#165).

emiliom commented 5 years ago

Closing. Discovered that bug was related to messy (bad) datetime strings in the tests/test_odm2/data/populated.sql test SQLite database ddl. Fixing that file, then submitting new PR.