ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.
http://odm2.github.io/ODM2PythonAPI/
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Fix SQLite Result ValueDateTime data-type regression bug and related test populated.sql db errors #169

Closed emiliom closed 5 years ago

emiliom commented 5 years ago

Fixes #158.

Tested on the timeseries notebook at https://github.com/ODM2/ODM2PythonAPI/blob/master/Examples/TimeSeries_RetrieveVisualize.ipynb

While testing and debugging, discovered that #158 was related to the presence of messy (bad/invalid) datetime strings in the tests/test_odm2/data/populated.sql test SQLite database ddl. Fixing that file in this PR.

emiliom commented 5 years ago

The main Travis CI TEST_TARGET ("default", Python 2.7) is passing. "coding_standards" test target is failing due to long-standing code patterns, but that doesn't get in the way of a successful build.

Appveyor CI hasn't been working for quite a while, so I'm ignoring its failures.

Merging PR.