ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.
http://odm2.github.io/ODM2PythonAPI/
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Add optional geospatial functionality #70

Open emiliom opened 8 years ago

emiliom commented 8 years ago

The recent PR #69 completed the removal of all geospatial capability (even optional ones) around SamplingFeatures.FeatureGeometry that started with a commit in early June that removed the shape method on the models.py SamplingFeatures class and related, geoalchemy-based functionality.

For convenience for future follow-ups, I'm pasting below some of my own comments from the discussions on PR #69:

more broadly, I don't agree with the complete removal of all geospatial capability that started in early June commits. I can definitely see the benefit of making that functionality more optional, including moving related import statements into the optional methods that use them (or even into a utilities module) so that packages like shapely and geoalchemy are not required. But that's different from removing all geospatial capability entirely. FYI, I believe Choonhan was relying on the shape function for ODM2RESTAPI, and I personally found it very useful and non-obtrusive, except requiring the installation of those geospatial packages.

TO-DO for me (Emilio):

cc'ing @lsetiawan, b/c I plan to start pulling him into odm2api development later this month. He's already built some ODM2 geodjango experience, and has a strong Python geospatial experience.

horsburgh commented 8 years ago

@emiliom - thanks for capturing this. We really needed to move forward with the API for several reasons and the geospatial stuff was holding us back. We just hadn't been able to figure it out. So, if we can get some help with this and figure out how to add it back in with support across the RDBMS, that would be awesome.

emiliom commented 7 years ago

Just for reference: two older issues with relevant discussions are #29 and #14. But specially #29!

Also note my old references to my sfgeometry_em_1 branch from Feb. 2016. That branch no longer exists on the github repo, but I probably still have it around on my local clone.

emiliom commented 7 years ago

Just saw this 1-year-old commit to ODM2RESTfulWebServices that's relevant to this topics/issue. I'm adding a link to it here for reference, to follow up once we focus on this topic in odm2api.

emiliom commented 7 years ago

Adding a link to PR #72 (removed dependencies to geoalchemy and shapely), which we just merged. It includes some possibly useful comments, PR's, etc.