search

ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.
http://odm2.github.io/ODM2PythonAPI/
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Reactivate Travis-CI #86

Closed ocefpaf closed 7 years ago

ocefpaf commented 7 years ago

This is a substitute for #74

I made several small commits to make it easier to review. It should be easier for the reviewer to navigate the commits in order.

Note that the tests are now running, but not passing. Most of them no longer make sense b/c they are outdated and disconnected from the latest code.

We should not only write new meaningful tests, but also write them together with the new code.

emiliom commented 7 years ago

@sreeder and @lsetiawan, can you review this PR from @ocefpaf? I suspect some areas may be outside your individual expertise, but we can work together on this with @ocefpaf's guidance. I won't be able to provide input until tomorrow (Thursday), and then @ocefpaf will be traveling starting on Friday.

Thanks!

emiliom commented 7 years ago

Everything looks good to me, except for the duplicated listing of pymssql and psycopg2 in requirements-dev.txt

ocefpaf commented 7 years ago

Everything looks good to me, except for the duplicated listing of pymssql and psycopg2 in requirements-dev.txt

Probably leftovers from a bad rebase. Latest commit should fix it.