Closed ocefpaf closed 7 years ago
@sreeder and @lsetiawan, can you review this PR from @ocefpaf? I suspect some areas may be outside your individual expertise, but we can work together on this with @ocefpaf's guidance. I won't be able to provide input until tomorrow (Thursday), and then @ocefpaf will be traveling starting on Friday.
Thanks!
Everything looks good to me, except for the duplicated listing of pymssql
and psycopg2
in requirements-dev.txt
Everything looks good to me, except for the duplicated listing of
pymssql
andpsycopg2
inrequirements-dev.txt
Probably leftovers from a bad rebase. Latest commit should fix it.
This is a substitute for #74
I made several small commits to make it easier to review. It should be easier for the reviewer to navigate the commits in order.
Note that the tests are now running, but not passing. Most of them no longer make sense b/c they are outdated and disconnected from the latest code.
We should not only write new meaningful tests, but also write them together with the new code.