Fix test - Githubissues

ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.

http://odm2.github.io/ODM2PythonAPI/

BSD 3-Clause "New" or "Revised" License

4 stars 13 forks source link

Fix test #92

Closed lsetiawan closed 7 years ago

lsetiawan commented 7 years ago

Overview

This PR is a follow up to #90 and #91. It fixes some of the failing test functions that seem to use an older version of ODM2PythonAPI.

Notes

I've change some of the function to use the latest ODM2Python API, and the tests now appear to pass in travis-ci. Some fixes that would be beneficial to further develop the tests includes

removing sudo during database creation in the shell script for mysql.
I am adding some comments on parts of the test that I think need further evaluation.

ocefpaf commented 7 years ago

LGTM. Merging b/c my comment above is syntax sugar and not a requirement.

Thanks @lsetiawan!