search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Created flask_notworking and moved files there that doesn't work #119

Closed lsetiawan closed 7 years ago

lsetiawan commented 7 years ago

I moved the stuff that are not being used in examples/flask to examples/flask_notworking. Let me know if I miss anything. cbi and swis are currently used in travis ci and odm1_1 and odm2 are the ones we are focusing.

This PR is related to ISSUE #72

split off into a new directory ("wof/examples/flask_notworking") the DAOs (directories) that have not been tested recently and will not be tested soon to ensure they work. For now, we're preserving and focusing only odm2 and odm_1_1)

emiliom commented 7 years ago

@lsetiawan, there was a discussion mostly with @ocefpaf, probably on a PR, where we decided to not do that "not working" directory separation after all. I don't remember which PR it was, so I can't point to the discussion.

I think I'm still on the balance between the two approaches, but I'll go with what we have now rather than accepting your PR. But first let me know if you have new arguments to make us go in this direction.

Thanks.

lsetiawan commented 7 years ago

@emiliom I guess I missed that memo. I don't have strong preference here. I'll close this PR then. Thanks.

ocefpaf commented 7 years ago

Just to clarify. Anyone using master should know that the code comes without any "warranties." So, keeping all the examples in the same location, is the saner option for the developers.

However, we should not ship broken code to end user! PR #103 updated the MANIFEST.in file and prevent those examples from making into the source distribution tarball.

emiliom commented 7 years ago

Thanks for the reminder and explanation, @ocefpaf!